Make branch detection warnings less annoying

This commit is contained in:
RisaDev
2024-11-18 02:47:09 +03:00
parent f03e43792f
commit cbc732d00a
4 changed files with 13 additions and 8 deletions

View File

@@ -9,7 +9,7 @@ public class DalamudBranchService : IService
/// Message used in various places to tell user why the plugin is disabled /// Message used in various places to tell user why the plugin is disabled
/// </summary> /// </summary>
public const string PluginDisabledMessage = "You are running development or testing version of Dalamud.\n" + public const string PluginDisabledMessage = "You are running development or testing version of Dalamud.\n" +
"Regular users are not supposed to run Customize+ on non-release versions of Dalamud therefore Customize+ has disabled itself."; "Regular users are not supposed to run Customize+ on non-release versions of Dalamud therefore Customize+ has disabled itself until you go back to stable version.";
/// <summary> /// <summary>
/// Current Dalamud branch /// Current Dalamud branch

View File

@@ -54,8 +54,8 @@ public class UserNotifierService : IDisposable
if (displayOptionalMessages) if (displayOptionalMessages)
{ {
if(_popupSystem.ShowPopup(PopupSystem.Messages.PluginDisabledNonReleaseDalamud))
UIGlobals.PlayChatSoundEffect(11); UIGlobals.PlayChatSoundEffect(11);
_popupSystem.ShowPopup(PopupSystem.Messages.PluginDisabledNonReleaseDalamud);
} }
} }
} }

View File

@@ -48,6 +48,6 @@ public partial class PopupSystem
RegisterPopup(Messages.ClipboardDataNotLongTerm, "Warning: clipboard data is not designed to be used as long-term way of storing your templates.\nCompatibility of copied data between different Customize+ versions is not guaranteed.", true, new Vector2(5, 10)); RegisterPopup(Messages.ClipboardDataNotLongTerm, "Warning: clipboard data is not designed to be used as long-term way of storing your templates.\nCompatibility of copied data between different Customize+ versions is not guaranteed.", true, new Vector2(5, 10));
RegisterPopup(Messages.PluginDisabledNonReleaseDalamud, DalamudBranchService.PluginDisabledMessage, false, new Vector2(5, 8)); RegisterPopup(Messages.PluginDisabledNonReleaseDalamud, DalamudBranchService.PluginDisabledMessage + "\nThis window will not be shown again.", true, new Vector2(5, 8));
} }
} }

View File

@@ -38,7 +38,10 @@ public partial class PopupSystem
_logger.Debug($"Popup \"{name}\" registered"); _logger.Debug($"Popup \"{name}\" registered");
} }
public void ShowPopup(string name) /// <summary>
/// Show popup. Returns false if popup will not be shown for some reason. (can only be shown once or awaiting to be shown)
/// </summary>
public bool ShowPopup(string name)
{ {
name = name.ToLowerInvariant(); name = name.ToLowerInvariant();
@@ -47,12 +50,14 @@ public partial class PopupSystem
var popup = _popups[name]; var popup = _popups[name];
if (popup.DisplayRequested || _configuration.UISettings.ViewedMessageWindows.Contains(name)) if (popup.DisplayRequested || (popup.DisplayOnce && _configuration.UISettings.ViewedMessageWindows.Contains(name)))
return; return false;
popup.DisplayRequested = true; popup.DisplayRequested = true;
//_logger.Debug($"Popup \"{name}\" set as requested to be displayed"); //_logger.Debug($"Popup \"{name}\" set as requested to be displayed");
return true;
} }
public void Draw() public void Draw()